- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.6k
deps: upgrade to libuv 1.30.1 #28511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    saghul
  
              
              approved these changes
              
                  
                    Jul 2, 2019 
                  
              
              
            
            
              
                    richardlau
  
              
              approved these changes
              
                  
                    Jul 2, 2019 
                  
              
              
            
            
| 👍 for fast-track. | 
              
                    santigimeno
  
              
              approved these changes
              
                  
                    Jul 2, 2019 
                  
              
              
            
            
| CI: https://ci.nodejs.org/job/node-test-pull-request/24215/ EDIT(cjihrig): CI was yellow. | 
              
                    bnoordhuis
  
              
              approved these changes
              
                  
                    Jul 2, 2019 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly the smallest libuv upgrade in Node.js ever. :-)
This upgrade is a small patch release, fixing compilation errors on Android, Cygwin, and uClibc - none of which are tested in the CI. PR-URL: nodejs#28511 Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
    
  targos 
      pushed a commit
      that referenced
      this pull request
    
      Jul 2, 2019 
    
    
      
  
    
      
    
  
This upgrade is a small patch release, fixing compilation errors on Android, Cygwin, and uClibc - none of which are tested in the CI. PR-URL: #28511 Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
    
  targos 
      added a commit
      that referenced
      this pull request
    
      Jul 2, 2019 
    
    
      
  
    
      
    
  
Notable changes:
* build:
  * Experimental support for building Node.js on MIPS architecture
    is back. #27992
* child_process:
  * The promisified versions of `child_process.exec` and
    `child_process.execFile` now both return a `Promise` which has the
	child instance attached to their `child` property.
	#28325
* deps:
  * Updated libuv to 1.30.1. #28449,
    #28511
    * Support for the Haiku platform has been added.
    * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to
	  1024.
    * `uv_fs_copyfile()` now works properly when the source and
	  destination files are the same.
* process:
  * A new method, `process.resourceUsage()` was added. It returns
    resource usage for the current process, such as CPU time.
	#28018
* src:
  * Fixed an issue related to stdio that could lead to a crash of the
    process in some circumstances.
	#28490
* stream:
  * Added a `writableFinished` property to writable streams. It
    indicates that all the data has been flushed to the underlying
	system. #28007
* worker:
  * Fixed an issue that prevented worker threads to listen for data on
    stdin. #28153
* meta:
  * Added Jiawen Geng (https://github.com/gengjiawen) to collaborators.
    #28322
PR-URL: #28508
    
    
  targos 
      added a commit
      that referenced
      this pull request
    
      Jul 3, 2019 
    
    
      
  
    
      
    
  
Notable changes:
* build:
  * Experimental support for building Node.js on MIPS architecture
    is back. #27992
* child_process:
  * The promisified versions of `child_process.exec` and
    `child_process.execFile` now both return a `Promise` which has the
	child instance attached to their `child` property.
	#28325
* deps:
  * Updated libuv to 1.30.1. #28449,
    #28511
    * Support for the Haiku platform has been added.
    * The maximum `UV_THREADPOOL_SIZE` has been increased from 128 to
	  1024.
    * `uv_fs_copyfile()` now works properly when the source and
	  destination files are the same.
* process:
  * A new method, `process.resourceUsage()` was added. It returns
    resource usage for the current process, such as CPU time.
	#28018
* src:
  * Fixed an issue related to stdio that could lead to a crash of the
    process in some circumstances.
	#28490
* stream:
  * Added a `writableFinished` property to writable streams. It
    indicates that all the data has been flushed to the underlying
	system. #28007
* worker:
  * Fixed an issue that prevented worker threads to listen for data on
    stdin. #28153
* meta:
  * Added Jiawen Geng (https://github.com/gengjiawen) to collaborators.
    #28322
PR-URL: #28508
    
  This was referenced Jul 3, 2019 
      
    
  BethGriggs 
      pushed a commit
        to BethGriggs/node
      that referenced
      this pull request
    
      Feb 26, 2020 
    
    
      
  
    
      
    
  
This upgrade is a small patch release, fixing compilation errors on Android, Cygwin, and uClibc - none of which are tested in the CI. PR-URL: nodejs#28511 Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
    
  BethGriggs 
      pushed a commit
      that referenced
      this pull request
    
      Mar 2, 2020 
    
    
      
  
    
      
    
  
This upgrade is a small patch release, fixing compilation errors on Android, Cygwin, and uClibc - none of which are tested in the CI. PR-URL: #28511 Backport-PR-URL: #31969 Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
      
     Merged
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    author ready
  PRs that have at least one approval, no pending requests for changes, and a CI started. 
  
    fast-track
  PRs that do not need to wait for 48 hours to land. 
  
    libuv
  Issues and PRs related to the libuv dependency or the uv binding. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This upgrade is a small patch release, fixing compilation errors on Android, Cygwin, and uClibc - none of which are tested in the CI.
I'd like to propose fast tracking this so that it can make it into the 12.6.0 release. It has already been run in the CI (as all libuv releases are these days), and is a very small release that fixes issues on untested platforms. cc: @nodejs/libuv
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes